Skip to content

Add new element Period in PassengerInformationActionStructure#190

Merged
TuThoThai merged 13 commits into
v2.3-wipfrom
sx_cr_action_validity
May 18, 2026
Merged

Add new element Period in PassengerInformationActionStructure#190
TuThoThai merged 13 commits into
v2.3-wipfrom
sx_cr_action_validity

Conversation

@haeckerbaer

Copy link
Copy Markdown
Collaborator

Pain point to solve:
On PtSituationElement level one can define multiple ValidityPeriods (onbound). However, on Consequence or PassengerInformationAction level one cannot distinguish between these periods! On Consequence level this is solved by providing a corresponding element "Period" that overwrites the top level periods if one has to distinguish. However, on action level no such element exists.

  • Alternatively, extend ValidityPeriod element on PtSituationElement level by an “id” so that each period may be referenced on action level.
  • Multiple ValidityPeriods might for example be necessary in case of road works that only affects pt objects periodically during the night.
  • Also, similar to how Interval on PushedActionStructure level supposedly works, a period (reference) on action level would enable a producer to publish some textual content via journey planner (Perspective ‘whilePlanningTrip’) before the situation actually affects the pt objects. This is not possible with PublicationWindow alone (which is independent from the ValidityPeriods). The only option here is to extend the ValidityPeriod which is certainly not desired for other Perspectives than 'whilePlanningTrip'.

A similar proposal was already discussed extensively within the SG7 group, but multiple counter proposals were suggested instead. These were all discussed within the UmS group (german speaking SX profile VDV736 that conceived the PassengerInformationActionStructure) but unfortunately were not able to solve the issues at hand.

@haeckerbaer haeckerbaer added this to the v2.3 milestone Nov 7, 2025
@haeckerbaer haeckerbaer self-assigned this Nov 7, 2025
@haeckerbaer haeckerbaer added enhancement New feature or request SX For everything SIRI-SX Needs CEN documentation Update These require CEN documentation update to match XSD & examples labels Nov 7, 2025
ue71603
ue71603 previously approved these changes Nov 8, 2025
@TuThoThai

Copy link
Copy Markdown
Collaborator

@haeckerbaer, I think it would be good to discuss this one further to reach a consensus. It would help for most of us to make a better use of SIRI-SX.

SteffenSuhr
SteffenSuhr previously approved these changes Nov 10, 2025

@SteffenSuhr SteffenSuhr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really necessary even for sending preliminary messages

@TuThoThai

Copy link
Copy Markdown
Collaborator

Since the consensus on this one only comes from stakeholders using the same implementation of SIRI SX, I would suggest to wait until consensus is found at the group level before merging.

@TuThoThai TuThoThai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a meeting to address all changes needed for ActionData, Affects & Consequences in SIRI-SX

@haeckerbaer haeckerbaer changed the base branch from integration to 2.3 December 19, 2025 11:33
@TuThoThai

Copy link
Copy Markdown
Collaborator

As per the meeting of 19 December 2025: Agreement to have ActionPeriod as an optional field, but there is the need to:

  • improve the description in the XSD to make it clearer when to use it
  • provide a couple of XML examples of how the messages will look like with several temporal elements in Actions related to the same Situation / Consequence
  • work on clean documentation with illustrations to be included in the next CEN documentation

@haeckerbaer haeckerbaer changed the title Add new element ActionPeriod in PassengerInformationActionStructure Add new element Period in PassengerInformationActionStructure Jan 28, 2026
@haeckerbaer haeckerbaer dismissed stale reviews from SteffenSuhr and ue71603 via db4742d January 28, 2026 08:27
ue71603
ue71603 previously approved these changes Jan 28, 2026
@TuThoThai TuThoThai requested a review from ue71603 April 6, 2026 15:05
Comment thread examples/siri_exm_SX/VDV736_exm/SX_ESAF_example.xml Outdated
Comment thread examples/siri_exm_SX/VDV736_exm/SX_ESAF_example.xml Outdated

@TuThoThai TuThoThai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spoted a couple of errors in the example file, I will let you check them @haeckerbaer unless you want me to edit the example directly

@haeckerbaer haeckerbaer requested a review from TuThoThai May 13, 2026 07:41
@haeckerbaer

Copy link
Copy Markdown
Collaborator Author

@TuThoThai fixed validation errors and also added second example

@SteffenSuhr SteffenSuhr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is urgently needed for the next version of VDV 736. In my opinion, the consultation process is complete.

@TuThoThai

Copy link
Copy Markdown
Collaborator

This is urgently needed for the next version of VDV 736. In my opinion, the consultation process is complete.

I understand the need but there was a long gap I could not control between my previous review and doing the change requested. 😄

@TuThoThai TuThoThai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for editing the example and adding the difference with / without the Period

Not blocking for the merge: at a later stage, we should revisit all examplex with xml:lang to ensure the attribute is filled in lowercase as per @skinkie remark in PR #210

@TuThoThai TuThoThai merged commit ea8080e into v2.3-wip May 18, 2026
@TuThoThai TuThoThai deleted the sx_cr_action_validity branch May 18, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Needs CEN documentation Update These require CEN documentation update to match XSD & examples SX For everything SIRI-SX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants